New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public assets 404 Not Found with Nitro publicAssets maxAge is set. #26517

Open

ploca14 opened this issue Mar 27, 2024 · 6 comments · May be fixed by #26679

Labels

3.x nitro pending triage upstream

ploca14 commented Mar 27, 2024

Environment

Operating System: Linux
Node Version: v18.18.0
Nuxt Version: 3.11.1
CLI Version: 3.11.1
Nitro Version: 2.9.5
Package Manager: npm@10.2.3
Builder: -
User Config: devtools, nitro
Runtime Modules: -
Build Modules: -

Reproduction

https://stackblitz.com/edit/github-kjtmai?file=nuxt.config.ts

Describe the bug

When attempting to set Cache-Control headers for assets using the maxAge option using the nitro.publicAssets option, causes the assets to return a 404 error.

Additional context

No response

Logs

No response

The text was updated successfully, but these errors were encountered:

ploca14 added 3.x pending triage labels

stackblitz bot commented Mar 27, 2024

Start a new pull request in StackBlitz Codeflow.

github-kjtmai (Open reproduction)

Member

danielroe commented Mar 30, 2024

Would you see if you can reproduce this in pure Nitro (reproduction sandbox), and if so, raise there? 🙏

danielroe added nitro upstream labels

Member

userquin commented Apr 6, 2024

dir seems to be not resolved (Nuxt aliases don't work, check Elk commit below), we need a resolver, here a working example (linked SB reproduction fork ):
https://stackblitz.com/edit/github-kjtmai-mrrd7c?file=nuxt.config.ts

Can be checked with Elk in dev server, check this commit elk-zone/elk@932af07 .

Screenshot using the playground in my Nuxt local clone:

Member

userquin commented Apr 6, 2024 •

edited

The problem seems to be also in nuxt, it is ignoring the aliases in layers:

Nuxt should resolve the paths properly, checking if using some alias: https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/core/nitro.ts#L156-L159
Nitro should include some protection, for example checking it the path is absolute (just check if already resolved, or require dir to be resolved): https://github.com/unjs/nitro/blob/c5d550ac33cba2f3fc46cc52cf8d63312cc25f08/src/options.ts#L334-L339 (pathe resolve seems to handle absolute paths properly, so the problem seems to be here)

It seems server routes with same problem.

Member

userquin commented Apr 6, 2024 •

edited

publicAssets not being resolved, only public dirs

Member

userquin commented Apr 6, 2024 •

edited

I'm preparing a PR for publicAssets, including also Nuxt alias:

userquin linked a pull request

that will close this issue

fix(nuxt): resolve nitro config entries in layers (nuxt aliases) #26679

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment