fix(nuxt): resolve nitro config entries in layers (nuxt aliases) #26679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
userquin
commented
Apr 6, 2024
packages/nuxt/src/core/nitro.ts
Outdated
| const { dir: rootDir, srcDir, alias: rootAlias } = nuxt.options | ||
| await Promise.all(nuxt.options._layers.map((layer) => { | ||
| return Promise.all((layer.config.nitro?.publicAssets || []).map(async (publicAsset) => { | ||
| if (!publicAsset) { |
There was a problem hiding this comment.
shold we use !publicAssets?.dir instead: if so, we should also remove || rootDir.public || 'public' from L617 and || layer.config.dir?.public || 'public'from L618
There was a problem hiding this comment.
I've exluded publicAssets without dir
userquin
commented
Apr 6, 2024
| const dir = await resolvePath(path, { cwd, alias: alias as Record<string, string> }) | ||
| // TODO: should warn if missing? | ||
| if (existsSync(dir)) { | ||
| publicAsset.dir = dir |
There was a problem hiding this comment.
should warn or even throw?
userquin
changed the title
userquin
changed the title
chore: include scanDirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 Linked issue
resolves #26517
馃摎 Description
publicAssetsandpublicfolders not being resolved and so we cannot use Nuxt alias.This PR also includes layers public directories to nitro configuration.