Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): respect injectScripts for target:static #8912

Merged
merged 1 commit into from Mar 1, 2021

Conversation

hanneskuettner
Copy link

@hanneskuettner hanneskuettner commented Feb 27, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #8866 where injectScripts: false was not respected when generating full static pages.
As far as I can see this should not influence any target other than static since renderContext.staticAssetsBase in not set otherwise.

Also added a test to verify the change works.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you ❤️

@clarkdo clarkdo changed the title fix: respect injectScripts for target:static fix(vue-renderer): respect injectScripts for target:static Mar 1, 2021
@clarkdo clarkdo merged commit 07e97f1 into nuxt:dev Mar 1, 2021
@hanneskuettner hanneskuettner deleted the fix/respect-inject-scripts branch March 1, 2021 22:45
@pi0 pi0 mentioned this pull request Mar 9, 2021
This was referenced Mar 10, 2021
This was referenced Mar 15, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
danielroe pushed a commit that referenced this pull request Feb 4, 2023
@danielroe danielroe mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full static doesn't respect injectScripts: false
3 participants