New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): allow files with .cjs
extension to be transpiled
#10340
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10340 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 94 94
Lines 4155 4155
Branches 1172 1172
=======================================
Hits 2709 2709
Misses 1167 1167
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There is also this line that maybe should be updated also: |
@rchl Agreed. Would you update that one as well? |
I will but note that the fix works without this change so I'm not sure what's the exact purpose of this. |
Any plans to merge and release a new Nuxt 2 version? |
.cjs
extension to be transpiled
Thanks for working on this pull request @rchl and sorry it took long to merge. CI was failing because of dependencies. And indeed we plan to make at least two minor versions for Nuxt 2 and including this fix as well. |
.cjs
extension to be transpiled.cjs
extension to be transpiled
Fixes #10339
Types of changes
Description
Not sure if you consider it a bug fix or a feature but it seems like a bug to me.
Resolves #10339
Checklist: