New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): provide node16-style type exports #18431
Conversation
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
minor notice: the issue mentioned is not linked properly because of a typo in "resolves" π€« |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this π₯
Okay, so that's why I kept it in: https://github.com/nuxt/nuxt/actions/runs/4363710497/jobs/7630133013 |
Strange... It is vitest or jiti? (jiti fallsback to |
I think it's neither - I think it's the call to nuxt/packages/nuxi/src/utils/cjs.ts Lines 20 to 22 in e05f8ee
Replicable with built monorepo: ./packages/nuxi/bin/nuxi.mjs prepare test/fixtures/basic |
π Linked issue
#19606
β Type of change
π Description
This PR makes some updates to Nuxt internals to improve support for Node16-style module resolution.
π Current status
nuxt v3.2.3
"nuxt"
"nuxt/config"
"nuxt/schema"
"nuxt/app"
"nuxt/package.json"
node10
node16
(from CJS)node16
(from ESM)bundler
nuxt (edge)
"nuxt3"
"nuxt3/config"
"nuxt3/schema"
"nuxt3/kit"
"nuxt3/app"
"nuxt3/package.json"
node10
node16
(from CJS)node16
(from ESM)bundler
after this pr
"nuxt"
"nuxt/config"
"nuxt/schema"
"nuxt/kit"
"nuxt/app"
"nuxt/package.json"
node10
node16
(from CJS)node16
(from ESM)bundler
See https://arethetypeswrong.github.io.
the remaining blockers for full support for Node16 format can be tracked in #19606.
π Checklist