fix(schema): show payloadExtraction warning only when unset

[hslee2008]

🔗 Linked issue

No linked issue.

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is only a minor change and I am not sure if it is a good one.

This change should be made because when users sets experimental.payloadExtraction to true on purpose, they are hinting that either they are doing this on purpose or wanting the warnings to be gone.

This code change only changes the code so that if the enabled property is undefined (meaning the user did not set any configuration), it shows the warnings, but if the user sets it to true there will be no warnings.

🧪 Tests / Examples

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[danielroe]

This is a nice change, thank you!

[danielroe]

Oops, my apologies; I forgot how we are doing this. In fact we set this here:

https://github.com/nuxt/nuxt.js/blob/6e78f9dbb03a059814d1284511f732b901dea4f6/packages/nuxi/src/commands/build.ts#L30-L34

So we don't want to show warning always if it is null or undefined because it is only on prerendering that it is in fact enabled, and in that case it is because it is set to true.

[hslee2008]

I pressed the wrong button. Sorry.

[hslee2008]

Oops, my apologies; I forgot how we are doing this. In fact we set this here:

https://github.com/nuxt/nuxt.js/blob/6e78f9dbb03a059814d1284511f732b901dea4f6/packages/nuxi/src/commands/build.ts#L30-L34

So we don't want to show warning always if it is null or undefined because it is only on prerendering that it is in fact enabled, and in that case it is because it is set to true.

I want to work on this, but I am not exactly sure how it works.

Could you explain it a bit more? I am not sure what prerender is nor how to get the argument prerender in the experimental.ts file.

Or could you help me on this?

implemented differently