Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-app): handle promise rejection from asyncData #18585

Merged
merged 6 commits into from Feb 21, 2023
Merged

fix(vue-app): handle promise rejection from asyncData #18585

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ed63bb
fix(vue-app): unhandled promise rejection when handling asyncData
rchl Jan 27, 2023
196a808
Merge branch '2.x' into fix/unhandled-promise
rchl Feb 13, 2023
0475eca
Merge branch '2.x' into fix/unhandled-promise
danielroe Feb 17, 2023
f461e36
better fix?
rchl Feb 17, 2023
4f9bf4f
Merge branch '2.x' into fix/unhandled-promise
danielroe Feb 17, 2023
b970d5f
Merge branch '2.x' into fix/unhandled-promise
danielroe Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/vue-app/template/server.js
View file
Open in desktop
Expand Up @@ -321,8 +321,7 @@ const render404Page = () => {
promise.then((asyncDataResult) => {
ssrContext.asyncData[Component.cid] = asyncDataResult
applyAsyncData(Component)
return asyncDataResult
})
}).catch(() => {})
danielroe marked this conversation as resolved.
Show resolved Hide resolved
danielroe marked this conversation as resolved.
Show resolved Hide resolved
promises.push(promise)
} else {
promises.push(null)
Expand Down