Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): provide fallback values for undefined runtime config #18586

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 27, 2023

πŸ”— Linked issue

resolves #13845

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Whilst working on a PR to improve docs, spotted an opportunity to remove one of the non-intuitive pieces of the docs (the fact that you have to give everything a value - it's not enough to point it to an undefined env variable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Jan 27, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 27, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good idea. We could also add it to upstream nitro for default and consistent beahvior

@danielroe danielroe merged commit b8f6243 into main Jan 28, 2023
@danielroe danielroe deleted the fix/runtime-config branch January 28, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better way to set runtimeConfig fallbacks
2 participants