Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): dedupe vue-router #18626

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(nuxt): dedupe vue-router #18626

merged 1 commit into from
Jan 30, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #15434

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's happened a couple of times that multiple versions of vue-router have caused issues with undefined routes. This PR aims to deduplicate these imports.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Jan 30, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested review from pi0 and antfu January 30, 2023 13:47
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it solves any issue

@danielroe danielroe merged commit a0085b7 into main Jan 30, 2023
@danielroe danielroe deleted the fix/dedupe-vue-router branch January 30, 2023 18:22
@danielroe danielroe mentioned this pull request Feb 1, 2023
@purpleadlabdevops
Copy link

Hi everyone! I got a lot of warnings in the console in DevTools with the flag --inspect for node. This is a started project (v3.1.2) just with one page (it has just one title h1). If I remove a 'pages' directory - warnings are gone.

Π—Π½Ρ–ΠΌΠΎΠΊ Π΅ΠΊΡ€Π°Π½Π° 2023-02-08 ΠΎ 19 14 41

@danielroe
Copy link
Member Author

Would you be able to create a new issue with a reproduction? πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined route in Nuxt layout component in prod build
3 participants