feat: add back postcss-preset-env
#18704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
[release] resolves nuxt/framework#494
* chore: update logo * chore: update link to community
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
|
|
This was referenced Feb 2, 2023
Codecov ReportBase: 65.19% // Head: 66.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #18704 +/- ##
==========================================
+ Coverage 65.19% 66.55% +1.35%
==========================================
Files 94 93 -1
Lines 4155 4075 -80
Branches 1172 1149 -23
==========================================
+ Hits 2709 2712 +3
+ Misses 1167 1103 -64
+ Partials 279 260 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pi0
previously approved these changes
Feb 2, 2023
|
We need to test edge against tailwindcss module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR updates #9671 to add back
postcss-preset-env, which is now updated for PostCSS8. This reduces the breaking change surface of the linked PR.We might also consider reverting the breaking changes to postcss options in order to make this more manageable as a migration step. What do you think @pi0 - is there a reason we need to make the following change?
build.postcsshas been moved to postss-loader options format:build.postcss.pluginstobuild.postcss.postcssOptions.plugins, the object format is still samebuild.postcss.ordertobuild.postcss.postcssOptions.orderNote: to reduce the clutter of commits this is marked as a PR against
2.xbut before merge I will update to merge into #9671 and thence into2.x.