Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxi): warn when prerendering routes with ssr: false #18783

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #12393

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We can warn when users have ssr: false enabled but are running nuxi generate. This is almost always the wrong choice although it may be desirable in a small subset of cases.

I've also updated the documentation to make this clearer.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 5, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added the 3.x label Feb 6, 2023
@danielroe danielroe merged commit 85881b4 into main Feb 6, 2023
@danielroe danielroe deleted the feat/warn-ssr-false branch February 6, 2023 23:25
@danielroe danielroe mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is not very clear regarding static site generation in Nuxt 3
3 participants