Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack): client-side typechecking when ssr: false #18828

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix(webpack): client-side typechecking when ssr: false #18828

merged 1 commit into from
Feb 6, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #18818

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were not inserting the typechecker with ssr: false. This resolves that and also enables vue file handling.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Feb 6, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe removed the request for review from clarkdo February 6, 2023 17:18
@danielroe danielroe merged commit d998c16 into main Feb 6, 2023
@danielroe danielroe deleted the fix/webpack-spa-types branch February 6, 2023 18:35
@danielroe danielroe mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkdo clarkdo clarkdo approved these changes

Assignees

@danielroe danielroe

Labels
bug webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build does not perform type checking with webpack
2 participants
@danielroe @clarkdo