Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run webpack/vite and dev/prod as matrices #18905

Merged
merged 36 commits into from
Feb 13, 2023
Merged

ci: run webpack/vite and dev/prod as matrices #18905

merged 36 commits into from
Feb 13, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 🧹 Chore
  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This moves webpack/vite and dev/prod into a matrix to run in parallel. It also adds back webpack dev test which have omitted for some time. Nevertheless I hope this makes CI somewhat faster to run than previously.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the chore label Feb 8, 2023
@danielroe danielroe self-assigned this Feb 8, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 8, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
ci: update build condition
bb502fc
@danielroe
test: fix condition
cf96ddc
@danielroe
test: move away from boolean envs
481009c
@danielroe
Merge remote-tracking branch 'origin/main' into ci/matrix-test
8869428
@danielroe
test: set dev mode explicitly
fb10f92
@danielroe
test: use isDev()
7751828
@danielroe
refactor: move overrides into test
2b390f5
@danielroe
test: webpack dev tests for now
a5e1baa
@danielroe
ci: try wrapping in barces
835ad78
@danielroe
ci: refactor
30419f4
@danielroe
test: fix condition and add webpack todo
c6c0cd4
@danielroe
ci: run typecheck and unit test within matrix as well
9502cf9
@danielroe
ci: combine build + type testing
3674d3e
@danielroe
ci: try using artifact upload
24e27f7
@danielroe
ci: try preferring offline packages
8054ee8
@danielroe
ci: reenable original build-release script
9be488d
@danielroe
test: wait for 10ms to ensure all logs are included
e9b6e5f
@danielroe
ci: wait for longer to get logs on windows
6288253
@danielroe
ci: add some enhancements based on vitejs/vite
cb8b033
@danielroe
ci: remove duplicate playwright cache
7994f06
@danielroe
test: use polling for root nodes test
549293e
@danielroe
Merge branch 'main' into ci/matrix-test
fcc6045
@danielroe
test: use it.each
f19e5c8
@danielroe
ci: don't cancel runs on the main branch
48106c5
@danielroe
test: try splitting out hmr test into separate test file
e797090
@danielroe
chore: ignore import order in test files
e11f8d6
@danielroe danielroe marked this pull request as ready for review February 10, 2023 15:56
@danielroe danielroe requested review from manniL and pi0 February 10, 2023 16:07
@danielroe
Copy link
Member Author

This isn't perfect but it feels less flakey than before, and is also somewhat faster.

manniL
manniL reviewed Feb 11, 2023
View reviewed changes
package.json Show resolved Hide resolved
@danielroe danielroe added this pull request to the merge queue Feb 13, 2023
Merged via the queue into main with commit d036d3d Feb 13, 2023
@danielroe danielroe deleted the ci/matrix-test branch February 13, 2023 22:09
@danielroe danielroe mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielroe @manniL @pi0