Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): expose nuxt/schema subpath for augmentation #18922

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 9, 2023

πŸ”— Linked issue

resolves #18807, resolves #18512, resolves nuxt/content#1884

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR moves Nuxt to use a single target for augmenting Nuxt options to avoid collisions between different versions of schema in a project. (While there can be multiple versions of schema, there should only be ever one installation of nuxt as this is a devDependency of layers and modules.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 9, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@danielroe danielroe changed the title refactor(nuxt): expose nuxt/schema subpath for augmentation fix(nuxt): expose nuxt/schema subpath for augmentation Feb 9, 2023
@danielroe danielroe requested a review from antfu February 10, 2023 11:33
@danielroe danielroe added this pull request to the merge queue Feb 13, 2023
Merged via the queue into main with commit 6016aef Feb 13, 2023
@danielroe danielroe deleted the refactor/schema-export branch February 13, 2023 22:42
@danielroe danielroe mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants