Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): allow type inference of arrays in runtime config #18931

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix(schema): allow type inference of arrays in runtime config #18931

merged 2 commits into from
Feb 10, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #18925

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is a fix for inferred runtime type hints in runtimeConfig for keys that have arrays in the runtime config.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Feb 9, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 9, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit 19bef5a Feb 10, 2023
@danielroe danielroe deleted the fix/array-types branch February 10, 2023 07:36
@danielroe danielroe mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
bug ❗ p4-important schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type errors when using arrays in runtimeConfig
1 participant
@danielroe