-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): use parser to treeshake client-only declarations #18951
Merged
danielroe
merged 21 commits into
nuxt:main
from
huang-julien:fix/treeshake_variable_declaration
Feb 16, 2023
Merged
fix(nuxt): use parser to treeshake client-only declarations #18951
danielroe
merged 21 commits into
nuxt:main
from
huang-julien:fix/treeshake_variable_declaration
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
I think this PR should be ready now. Also the plugin is ... "a bit more readable". If there's anything to add, please let me know π |
Merged
danielroe
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - this is a nice improvement β€οΈ
danielroe
changed the title
fix(nuxt): use parser to treeshake variable declaration instead of Regex
fix(nuxt): use parser to treeshake client-only declarations
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolve #18949
β Type of change
π Description
Hi π ,
Using a regex to treeshake a variable declaration of a component isn't enough. This PR will use the parser to treeshake variables declarations of components that are only called client-side.
Done:
To do :
π Checklist