Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt): allow tree-shaking empty meta from build #19032

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because we output an empty object we are not able to tree-shaking empty meta objects out of the build. By setting to null instead, we can leverage rollup's ancient powers to bring order to the natural world.

Before (no minification)

  {
    name: (__nuxt_page_meta$1 == null ? void 0 : __nuxt_page_meta$1.name) ?? "about",
    path: (__nuxt_page_meta$1 == null ? void 0 : __nuxt_page_meta$1.path) ?? "/about",
    children: [],
    meta: __nuxt_page_meta$1,
    alias: (__nuxt_page_meta$1 == null ? void 0 : __nuxt_page_meta$1.alias) || [],
    redirect: (__nuxt_page_meta$1 == null ? void 0 : __nuxt_page_meta$1.redirect) || void 0,
    component: () => __vitePreload(() => import("./about.js"), true ? ["./about.js","./nuxt-link.js"] : void 0, import.meta.url).then((m) => m.default || m)
  },

After (no minification)

  {
    name: "about",
    path: "/about",
    children: [],
    meta: {},
    alias: [],
    redirect: void 0,
    component: () => __vitePreload(() => import("./about.js"), true ? ["./about.js","./nuxt-link.js"] : void 0, import.meta.url).then((m) => m.default || m)
  },

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 14, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit 59a1f7b into main Feb 14, 2023
@danielroe danielroe deleted the perf/meta branch February 14, 2023 22:22
@danielroe danielroe mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants