Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add versions to runtime nuxtApp #19064

Merged
merged 6 commits into from Mar 1, 2023
Merged

feat(nuxt): add versions to runtime nuxtApp #19064

merged 6 commits into from Mar 1, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 15, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a runtime versions object, similar to the one available on nuxtApp.vueApp.version (which corresponds to the Vue version). This can be used for debugging and feature detection. It can be accessed with useNuxtApp().versions within user code.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 15, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added this to the v3.3 milestone Feb 15, 2023
@manniL
Copy link
Member

manniL commented Feb 15, 2023

Should this be documented somewhere?

packages/nuxt/src/app/nuxt.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title feat(nuxt): add version to runtime nuxtApp feat(nuxt): add versions to runtime nuxtApp Mar 1, 2023
@danielroe danielroe merged commit d4a7524 into main Mar 1, 2023
@danielroe danielroe deleted the feat/version branch March 1, 2023 15:08
danielroe added a commit to Baroshem/nuxt that referenced this pull request Mar 2, 2023
@danielroe danielroe mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants