Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxi): reload nuxt when restart hook is called #19084

Merged
merged 7 commits into from Mar 1, 2023
Merged

feat(nuxi): reload nuxt when restart hook is called #19084

merged 7 commits into from Mar 1, 2023

Conversation

Baroshem
Copy link
Contributor

🔗 Linked issue

#18678

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #18678

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 16, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

pi0
pi0 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Baroshem @pi0
Update packages/nuxi/src/commands/dev.ts
240615a 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe danielroe added this to the v3.3 milestone Feb 16, 2023
@danielroe danielroe changed the title feat-#18678: add restart hook feat(nuxi): reload nuxt when restart hook is called Feb 16, 2023
danielroe
danielroe approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

(Deferring to v3.3 release as it's a feature.)

@danielroe danielroe merged commit 5cfd835 into nuxt:main Mar 1, 2023
@pi0 pi0 mentioned this pull request Mar 1, 2023
Closed
@danielroe danielroe mentioned this pull request Mar 8, 2023
Merged
@renovate renovate bot mentioned this pull request Apr 4, 2023
Open
1 task
@renovate renovate bot mentioned this pull request May 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@manniL manniL manniL approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x cli enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.

Add hook to restart the nuxt server
4 participants
@Baroshem @manniL @pi0 @danielroe