Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pages): add example of limiting scanned routes #19181

Merged
merged 6 commits into from
Feb 21, 2023
Merged

docs(pages): add example of limiting scanned routes #19181

merged 6 commits into from
Feb 21, 2023

Conversation

joel-wenzel
Copy link
Contributor

@joel-wenzel joel-wenzel commented Feb 21, 2023 •
edited

🔗 Linked issue

#19155

❓ Type of change

  • [x ] 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Update docs to include an example of how to limit page generation
Resolves #19155

📝 Checklist

  • [ x] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Ill update the docs as long as @danielroe is ok with the change.

@codesandbox
Copy link

codesandbox bot commented Feb 21, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@joel-wenzel joel-wenzel mentioned this pull request Feb 21, 2023
Closed
@Atinux Atinux changed the title feat (pages): custom glob matcher feat(pages): custom glob matcher Feb 21, 2023
@danielroe Volta.net
Copy link
Member

This is a nice implementation. I think if we did support this we should probably support an object for pages to preserve the ability to add more config options.

Added a comment in the linked issue. Let's discuss there for now before moving forward on this PR.

@joel-wenzel joel-wenzel changed the title feat(pages): custom glob matcher docs(pages): Limiting pages example Feb 21, 2023
danielroe
danielroe reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few minor wording changes.

docs/2.guide/2.directory-structure/1.pages.md Outdated Show resolved Hide resolved
docs/2.guide/2.directory-structure/1.pages.md Outdated Show resolved Hide resolved
docs/2.guide/2.directory-structure/1.pages.md Outdated Show resolved Hide resolved
joel-wenzel and others added 3 commits February 21, 2023 07:33
@joel-wenzel @danielroe
Update docs/2.guide/2.directory-structure/1.pages.md
367f5fe 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@joel-wenzel @danielroe
Update docs/2.guide/2.directory-structure/1.pages.md
ddc6078 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@joel-wenzel @danielroe
Update docs/2.guide/2.directory-structure/1.pages.md
4fefc1d 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe changed the title docs(pages): Limiting pages example docs(pages): add example of limiting scanned routes Feb 21, 2023
@danielroe danielroe merged commit b1fd520 into nuxt:main Feb 21, 2023
@danielroe
Copy link
Member

Thank you very much ❤️

@danielroe danielroe mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ability to configure glob pattern used to match pages
2 participants
@joel-wenzel @danielroe