Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): preserve (re)named imports in meta #19192

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #19126

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were wrongly preserving imports with reference to the keys (the name in the imported module) rather than the values (the name in the local scope).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug label Feb 21, 2023
@danielroe danielroe self-assigned this Feb 21, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 21, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit c4eb4b7 into main Feb 21, 2023
@danielroe danielroe deleted the fix/meta-named-imports branch February 21, 2023 12:22
@danielroe danielroe mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imports not defined in definePageMeta middleware
2 participants