Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improved going further modules documentation #19219

Merged
merged 7 commits into from
Feb 22, 2023
Merged

docs: improved going further modules documentation #19219

merged 7 commits into from
Feb 22, 2023

Conversation

rafaelmagalhaes
Copy link
Contributor

@rafaelmagalhaes rafaelmagalhaes commented Feb 22, 2023 •
edited

🔗 Linked issue

nuxt/starter#261

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added documentation on how to use addImports and addImportsDir along with a disclaimer that by default add imports is disabled in the starter kit template

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@lihbr
Copy link
Member

lihbr commented Feb 22, 2023

Thank you so much for contributing!

Just referencing it here also in case you're interested in having a look, but we're in the process of revamping the module author guide to be more complete: #18551 (comment), if you have any opinion on the outline suggested there feel free to join the conversation~

@danielroe danielroe merged commit 99a47c1 into nuxt:main Feb 22, 2023
@rafaelmagalhaes rafaelmagalhaes deleted the docs-modules-update branch February 22, 2023 16:02
@danielroe danielroe mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihbr lihbr lihbr approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafaelmagalhaes @lihbr @danielroe @rafaelmagalhaes-yapily