feat(vite): add node_modules and buildDir to x_google_ignoreList
#19243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nice! I just captured this in our tracking doc. 👍 |
9 tasks
bmeurer
reviewed
Mar 3, 2023
| @@ -63,6 +63,9 @@ export async function bundle (nuxt: Nuxt) { | |||
| copyPublicDir: false, | |||
| rollupOptions: { | |||
| output: { | |||
| sourcemapIgnoreList: (relativeSourcePath) => { | |||
| return relativeSourcePath.includes('/node_modules/') || relativeSourcePath.includes(ctx.nuxt.options.buildDir) | |||
There was a problem hiding this comment.
Does this work on Windows? For rollup I had to change it to relativeSourcePath.includes('node_modules') to make the test pass on the Windows bot.
Merged
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Rollup now supports (rollup/rollup#4848) adding certain files to the
x_google_ignoreListsource map extension. We can opt-in to this to provide a better default experience on Chrome.Limitations: This is a specific enhancement only for vite. More significantly, at the moment this is only processed in the rollup/vite production build rather than in development, which is a bit of a pain.
I've marked this as draft to investigate further. It might require an upstream vite enhancement.This will need to be enabled upstream in vite first before being configurable here.📝 Checklist