Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): update vite import.meta types #19338

Merged
merged 7 commits into from Mar 3, 2023
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Feb 28, 2023

πŸ”— Linked issue

Fix #15645

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

Sync ImportMeta from Vite and try to import from Vite exported types.

@codesandbox
Copy link

codesandbox bot commented Feb 28, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added this to the v3.3 milestone Mar 2, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. ❀️

@danielroe danielroe changed the title fix(schema): sync import meta type from vite fix(schema): update vite import.meta types Mar 3, 2023
@danielroe danielroe merged commit 654b9a2 into main Mar 3, 2023
@danielroe danielroe deleted the fix/import-meta-type branch March 3, 2023 10:20
@clarkdo
Copy link
Member Author

clarkdo commented Mar 3, 2023

@danielroe What formatter rules are we following in nuxt now ? I don't see any prettier config, is it only editorconfig ?

Ignore me, seeing:

{
  "editor.codeActionsOnSave": {
    "source.fixAll": false,
    "source.fixAll.eslint": true
  }
}

@danielroe danielroe mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViteImportMeta import.meta.glob does not change types for the eager: true flag
2 participants