Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): clear loading indicator on unmount #19340

Merged
merged 1 commit into from Feb 28, 2023
Merged

fix(app): clear loading indicator on unmount #19340

merged 1 commit into from Feb 28, 2023

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 28, 2023

🔗 Linked issue

None

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Properly clear indicator on unmount (e.g. during page change or disabling)

@codesandbox
Copy link

codesandbox bot commented Feb 28, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit 639189c into main Feb 28, 2023
@danielroe danielroe deleted the fix/clear-loading-indicator branch February 28, 2023 19:18
@danielroe danielroe mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manniL @danielroe