Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): pass transform options to component loader plugin #19414

Merged
merged 3 commits into from Mar 3, 2023

Conversation

stenet
Copy link
Contributor

@stenet stenet commented Mar 3, 2023

πŸ”— Linked issue

resolves #19412

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As mentioned in #19412 the component/transform options are not passed to the loaderPlugin. Therefor it is currently not possible to include/exclude components from translating "_resolveComponent(...)" to an actual "import xx from 'xx'".

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 3, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❀️

@danielroe danielroe changed the title fix(nuxt): pass component transform options to loaderPlugin fix(nuxt): pass transform options to component loader plugin Mar 3, 2023
@danielroe danielroe merged commit 6084f64 into nuxt:main Mar 3, 2023
@danielroe danielroe mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransformOptions are not passed to LoaderPlugin
3 participants