New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nuxi): hard restart with communication channel #19423
Conversation
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Experimenting with #19394, I'm getting this error: ERROR [uncaughtException] Channel closed 15:03:45
at new NodeError (node:internal/errors:393:5)
at target.send (node:internal/child_process:740:16)
at packages/nuxi/src/commands/dev.ts:99:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) Following that error, programmatic restarts no longer work. |
Can you directly reproduce it in this branch? (you can use a hook in playground/nuxt.config) What is your node version? |
Co-authored-by: Daniel Roe <daniel@roe.dev>
I can reproduce reliably after a couple of saves. Reproduction: git checkout feat/modules-dir
git merge --squash origin/fix/cli-restart
pnpm nuxi dev test/fixtures/basic
# modify test/fixtures/basic/modules/example.ts Running on Node v18.12.1 |
Try again with latest commit :) |
Seems to be working well π |
π Linked issue
Followup unresolved fixes from #18641
β Type of change
π Description
Aligning (more) with next version of CLI, this PR improves dev wrapper implementation:
fork
to open a communication channelprocess.send
signalingπ Checklist