Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): don't print layout warning if page is not ssr #19434

Merged
merged 1 commit into from Mar 3, 2023
Merged

fix(nuxt): don't print layout warning if page is not ssr #19434

merged 1 commit into from Mar 3, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #19428

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We can ignore the warning from setPageLayout if the page isn't SSRed as there is no danger of a hydration mismatch.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Mar 3, 2023
@codesandbox
Copy link

codesandbox bot commented Mar 3, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0 pi0 changed the title fix(nuxt): don't print layout warning if site is not ssr fix(nuxt): don't print layout warning if page is not ssr Mar 3, 2023
@danielroe danielroe requested a review from pi0 March 3, 2023 16:37
@danielroe danielroe merged commit a420369 into main Mar 3, 2023
@danielroe danielroe deleted the fix/spa-layout branch March 3, 2023 16:47
@danielroe danielroe mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setPageLayout Middleware on client side rendering
2 participants
@danielroe @pi0