Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): support custom keyed composables #19490

Merged
merged 4 commits into from Mar 7, 2023
Merged

feat(nuxt): support custom keyed composables #19490

merged 4 commits into from Mar 7, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 6, 2023 •
edited

🔗 Linked issue

resolves #12369

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds support for creating custom keyed composables. Keys will be injected as a final argument as long as the number of arguments is less than the maximum argumentLength.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Mar 6, 2023
@codesandbox
Copy link

codesandbox bot commented Mar 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe marked this pull request as ready for review March 6, 2023 22:35
@danielroe danielroe requested review from pi0 and harlan-zw March 6, 2023 22:35
manniL
manniL approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only docs are missing 😋

@danielroe danielroe merged commit 60d07df into main Mar 7, 2023
@danielroe danielroe deleted the feat/custom-keyed-composables branch March 7, 2023 21:06
@danielroe danielroe mentioned this pull request Mar 8, 2023
Merged
@zhuoqi-chen
Copy link

I really need this feature, especially for the composable function which wrapper the useAsyncData . THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@harlan-zw harlan-zw harlan-zw approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add your own keyed functions
4 participants
@danielroe @zhuoqi-chen @manniL @harlan-zw