Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): use custom logger to show vite logs #19523

Merged
merged 3 commits into from Mar 8, 2023
Merged

feat(vite): use custom logger to show vite logs #19523

merged 3 commits into from Mar 8, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 8, 2023

πŸ”— Linked issue

Fix #13914

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

By providing our own custom logger, we are able to integrate Vite's log in a more organic way (using consola). Making it supports clearScreen and we no longer need to hide Vite's log with logLevel: 'warn' (I see this as one of the sources of confusion as sometimes it's not clear to the user what is going on when we hide log from Vite)

Kapture.2023-03-08.at.11.49.53.mp4

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 8, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe mentioned this pull request Mar 8, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely.

@danielroe danielroe changed the title feat(vite): customize vite logger feat(vite): use custom logger to show vite logs Mar 8, 2023
@danielroe danielroe merged commit 6243146 into main Mar 8, 2023
@danielroe danielroe deleted the feat/logger branch March 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear console on HMR
2 participants