Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite): allow disabling clear screen behaviour #19531

Merged
merged 3 commits into from Mar 9, 2023
Merged

fix(vite): allow disabling clear screen behaviour #19531

merged 3 commits into from Mar 9, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 8, 2023 •
edited

🔗 Linked issue

#13914

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This allows respecting vite.clearScreen option (which is set to false by default). If we want to enable by default we can do this here:

nuxt/packages/schema/src/config/vite.ts

Line 65 in 6243146

clearScreen: false,

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu March 8, 2023 16:31
@danielroe danielroe self-assigned this Mar 8, 2023
@codesandbox
Copy link

codesandbox bot commented Mar 8, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added the 3.x label Mar 8, 2023
@antfu
Copy link
Member

antfu commented Mar 8, 2023

Oh I missed it. I think we could enable it by default

@danielroe danielroe merged commit edaca1a into main Mar 9, 2023
@danielroe danielroe deleted the fix/vite-clear branch March 9, 2023 09:19
@danielroe danielroe mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu

Assignees

@danielroe danielroe

Labels
3.x bug vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @antfu