docs: warn about modules with side-effects #19592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolve #19506
β Type of change
π Description
Hi π
Some users reported that some of their pages fails to render due to
window
being undefined. The reason is this was caused by importing modules containing side-effects. Even if the user expect the code to work because it calls the import in aonMounted
, the component crash at render because the import is not treeshaken in server-side.This pr warns about importing modules with side-effects.
Maybe can it be improved by adding an example to the error handling ? Or as mentionned by @manniL , listing a small list of modules containing side-effects (leaflet) ?
π Checklist