fix(nuxt,schema): merge custom and resolved app configs #19602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#15592
β Type of change
π Description
This fixes a couple of type issues with the current config schema implementation, notably:
NuxtOptions
/NuxtConfig
were defined in conflicting ways - with two different definitions ofappConfig
- one extending CustomAppConfig and one extending the ResolvedAppConfig. In this PR we now merge the two, smartly choosing the type from CustomAppConfig but picking from ResolvedAppConfig whether or not the item is defined. We also do not include a key signature for CustomAppConfig.CustomAppConfig
was not in fact augmented previously - I've used a different type name for safety.π Checklist