Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): exclude boolean from inline module definitions #19621

Merged
merged 1 commit into from Mar 12, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There was an internal type incompatibility (and would replicate for any module that accepts top-level boolean) whereby we were declaring an explicit inline type for modules that did not satisfy the defined type for inline options (a Record).

The fix is simple and is non-breaking as it would have printed out a TS error anyway (Type 'boolean' is not assignable to type 'Record<string, any>'.ts(2322))

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 12, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title fix(nuxt): exclude boolean from inline definitions fix(nuxt): exclude boolean from inline module definitions Mar 12, 2023
@danielroe danielroe merged commit ea8f78a into main Mar 12, 2023
@danielroe danielroe deleted the fix/inline-module-types branch March 12, 2023 22:25
@danielroe danielroe mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant