Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add nitro:build:public-assets hook #19638

Merged
merged 5 commits into from Mar 14, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #14788

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a new hook (nitro:build:assets) to allow interacting or adding new public assets after they have been copied into nitro.options.output.publicDir.

Thoughts welcome on hook name (cc: @pi0).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 13, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ’―

@pi0
Copy link
Member

pi0 commented Mar 14, 2023

Should we call it nitro:build:public hook? πŸ€” (it is public assets)

@danielroe
Copy link
Member Author

If you think that's clearer. Or maybe 'nitro:build:public-assets' if that's not too much of a mouthful?

@pi0
Copy link
Member

pi0 commented Mar 14, 2023

I like clarity of full name πŸ‘πŸΌ

@danielroe danielroe changed the title feat(nuxt): add nitro:build:assets hook after copying public assets feat(nuxt): add nitro:build:public-assets hook Mar 14, 2023
@danielroe danielroe merged commit 9d850a2 into main Mar 14, 2023
@danielroe danielroe deleted the feat/nitro-assets branch March 14, 2023 10:34
@danielroe danielroe mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow modifying public assets after build (or in hook)
2 participants