Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): mark non-augmented NuxtApp properties as unknown #19643

Merged
merged 3 commits into from Mar 14, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #14495

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds more typings for internal NuxtApp properties, primarily for our own internal use. None of the properties marked as @internal should be relied on by end users.

It also updates the default typing of unknown properties on NuxtApp to unknown meaning it will properly respect end users' strictness settings and flag issues when the type is missing (for example, if a provided property is renamed).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 13, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe removed their assignment Mar 13, 2023
@danielroe danielroe merged commit 0f6276d into main Mar 14, 2023
@danielroe danielroe deleted the fix/nuxtapp-signature branch March 14, 2023 10:09
@danielroe danielroe mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better typings for useNuxtApp
1 participant