Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): use key to force server component re-rendering #19911

Merged
merged 14 commits into from Apr 20, 2023
Merged

fix(nuxt): use key to force server component re-rendering #19911

merged 14 commits into from Apr 20, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Mar 24, 2023 •
edited

🔗 Linked issue

resolve #19884

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

hi 👋

This PR fix #19884 by wrapping the staticNode within a functionnal component and adding a key to it to force re-render the staticVNode
It also use NuxtIsland for .server component

📝 Checklist and TODO

  • I have linked an issue or discussion.
  • Implement Tests fixtures for server components re-rendering

@codesandbox
Copy link

codesandbox bot commented Mar 24, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@huang-julien huang-julien mentioned this pull request Mar 24, 2023
Closed
19 tasks
@huang-julien huang-julien marked this pull request as ready for review March 24, 2023 22:41
@huang-julien huang-julien marked this pull request as draft March 25, 2023 09:21
@huang-julien huang-julien marked this pull request as ready for review March 25, 2023 13:35
@huang-julien
Copy link
Member Author

#19851 includes this PR

@huang-julien
Copy link
Member Author

reopen in case of a minor fix patch

@huang-julien huang-julien reopened this Apr 14, 2023
@huang-julien huang-julien marked this pull request as draft April 20, 2023 19:59
@huang-julien huang-julien marked this pull request as ready for review April 20, 2023 20:34
@danielroe danielroe changed the title fix(nuxt): fix server component re-rendering in production fix(nuxt): use key to force server component re-rendering Apr 20, 2023
@danielroe danielroe merged commit e8e01ba into nuxt:main Apr 20, 2023
17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 20, 2023
Closed
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Islands components not updating in production
2 participants
@huang-julien @danielroe