New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): definePageMeta in "pages:extend" #19966
Conversation
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are fast!! π₯
The main issue I see here is that the page routes may change after the initial modules are loaded, for example if the user adds new files to the pages directory or there is some custom logic within a user pages:extend
hook that changes.
I see... then should we just transform both dirs and pages ? |
be68f98
to
19366f8
Compare
While reviewing, it occurred to me we could take the opportunity to rework how the page meta plugin works, which should improve performance more generally by having less parsing of the code. I've opened a PR at #20628. Would love your thoughts... π |
closing in favor of #20628 |
π Linked issue
#19955
β Type of change
π Description
Hi π , this PR add the result of the
page:extend
hook so pages added within modules can be also transformed.π Checklist