docs: add custom fetch composable example #20115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Live Preview ready!
|
adrienZ
force-pushed
the
docs/fetch-composable-exemple
branch
2 times, most recently
from
6dbbc79
to
3a7f42b
Compare
danielroe
changed the title
adrienZ
force-pushed
the
docs/fetch-composable-exemple
branch
from
2014a10
to
9baf841
Compare
danielroe
reviewed
Apr 24, 2023
| } | ||
|
|
||
| // for nice deep defaults, please use unjs/defu | ||
| const params = Object.assign(defaults, options) |
There was a problem hiding this comment.
nice idea! let's go ahead and use defu then
danielroe
reviewed
Apr 24, 2023
Comment on lines
16
to
18
| if (userAuth.value) { | ||
| options.headers.Authorization = `Bearer ${userAuth.value}` | ||
| } |
There was a problem hiding this comment.
we might also need to handle the case where this is a Headers object and we need to do headers.set(). For simplicity, is there any reason not to use the headers: {} option directly instead of within onRequest?
There was a problem hiding this comment.
tried something simpler :)
danielroe
reviewed
Apr 26, 2023
examples/other/use-custom-fetch-composable/composables/useCustomFetch.ts
Outdated
Show resolved
Hide resolved
danielroe
reviewed
Apr 26, 2023
examples/other/use-custom-fetch-composable/composables/useCustomFetch.ts
Outdated
Show resolved
Hide resolved
danielroe
reviewed
Apr 26, 2023
examples/other/use-custom-fetch-composable/composables/useCustomFetch.ts
Outdated
Show resolved
Hide resolved
danielroe
changed the title
Closed
|
should we close #14736 ? |
|
We also need to add some composables for modifying the inner behaviour of the data fetching composables, much as we have defineNuxtLink. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#14736
❓ Type of change
📚 Description
Adds an example in the
otherfolder of custom use fetch composable. It handles default values and auth but can be overriden.📝 Checklist