Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): allow keeping fallback for NuxtClientFallback #20336

Merged
merged 11 commits into from May 14, 2023
Merged

feat(nuxt): allow keeping fallback for NuxtClientFallback #20336

merged 11 commits into from May 14, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Apr 17, 2023 •
edited

🔗 Linked issue

resolve #20315

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋
This PR introduce a small feature to NuxtClientFallback to keep the fallback content once in client side if it failed in SSR

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 17, 2023 •
edited

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 641bd4a

@huang-julien huang-julien changed the title feat(nuxt): add keep-fallback strategy feat(nuxt): add keep-fallback strategy to NuxtClientFallback Apr 17, 2023
@huang-julien huang-julien marked this pull request as draft April 18, 2023 07:30
@huang-julien huang-julien marked this pull request as ready for review April 18, 2023 17:57
@danielroe danielroe added this to the v3.5 milestone May 2, 2023
@huang-julien
Copy link
Member Author

@danielroe I've implemented this as a string prop. Do you think we should make it a boolean ?

@danielroe
Copy link
Member

I'd also be happy with that 👍

@huang-julien
Copy link
Member Author

Great ! i'll update this tonight. There's seems to be an issue with webpack since the branch update -> will take a look and fix it 👀

@huang-julien huang-julien marked this pull request as draft May 12, 2023 06:48
@huang-julien
Copy link
Member Author

@danielroe i'm not sure when, but an update completly broke the component when using webpack 🤔

@danielroe
Copy link
Member

Hm. Maybe we could try locally bisecting the branch to see which it was?

@huang-julien
Copy link
Member Author

Found it, will open an issue + PR 🤔 not sure why it break when we have a transformInclude with vue&type=template

@huang-julien huang-julien mentioned this pull request May 13, 2023
Closed
@huang-julien huang-julien marked this pull request as ready for review May 13, 2023 23:12
@danielroe danielroe changed the title feat(nuxt): add keep-fallback strategy to NuxtClientFallback feat(nuxt): allow keeping fallback for NuxtClientFallback May 14, 2023
@danielroe danielroe merged commit 603e7e7 into nuxt:main May 14, 2023
19 checks passed
This was referenced May 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre left review comments

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.

Provide a strategy prop for NuxtClientFallback
3 participants
@huang-julien @danielroe @florian-lefebvre