Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): introduce vite:configResolved hook #20411

Merged
merged 1 commit into from Apr 29, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 20, 2023

πŸ”— Linked issue

danielroe/nuxt-vitest#130

#19968

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

For vite:extendConfig is intended to have the module modify the config, while in cases like nuxt-vitest, we want to retrieve the final configure passing to the Vite.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 20, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 20, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview e2bc770

@danielroe
Copy link
Member

It might be worth doing the same for webpack.

@danielroe danielroe merged commit 17ca503 into main Apr 29, 2023
18 checks passed
@danielroe danielroe deleted the feat/vite-config-resolved-hook branch April 29, 2023 22:37
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
@github-actions github-actions bot mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants