Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-utils): add option to configure test server port #20443

Merged
merged 5 commits into from Apr 29, 2023

Conversation

gjedlicska
Copy link
Contributor

πŸ”— Linked issue

#20442

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds an optional port value to the test-utils TestOptions interface.

This value enables pinning the test server's port when calling the setup function.

The feature is required for some integration test purposes, when the tested nuxt based server backend is expected to receive a callback from the service its being tested against. Without knowing the test server's port in advance, its a lot harder to configure these sorts of tests.

Resolves #20442

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 21, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 21, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 6660c76

@fabis94
Copy link

fabis94 commented Apr 25, 2023

Yes please!

@danielroe danielroe merged commit 4e7206b into nuxt:main Apr 29, 2023
18 checks passed
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
@github-actions github-actions bot mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable using manually set port in test-utils
3 participants