Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): use event.node.req in cookie utility #20474

Merged
merged 1 commit into from Apr 24, 2023
Merged

fix(nuxt): use event.node.req in cookie utility #20474

merged 1 commit into from Apr 24, 2023

Conversation

iamandrewluca
Copy link
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

event.req was deprecated in favour of event.node.req

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@iamandrewluca
fix(nuxt): use event.node.req in cookie
b444079 
`event.req` was deprecated in favour of `event.node.req`
@codesandbox
Copy link

codesandbox bot commented Apr 24, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

danielroe
danielroe approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielroe danielroe changed the title fix(nuxt): use event.node.req in cookie fix(nuxt): use event.node.req in cookie utility Apr 24, 2023
@danielroe danielroe merged commit ea1c5b2 into nuxt:main Apr 24, 2023
17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Closed
@iamandrewluca iamandrewluca deleted the patch-1 branch April 24, 2023 20:43
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamandrewluca @danielroe