Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxi,schema): support devServer.https: true #20498

Merged
merged 1 commit into from Apr 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#20435

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds support for setting devServer.https to true (rather than just an empty object) to enable SSL from within the nuxt.config.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 25, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit 4c200e4 into main Apr 25, 2023
17 checks passed
@danielroe danielroe deleted the fix/https-true branch April 25, 2023 14:33
@@ -18,7 +18,7 @@ export default defineUntypedSchema({
* ```
*
*
* @type {false | { key: string; cert: string }}
* @type {boolean | { key: string; cert: string }}
*
*/
https: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This couldn’t be true after normalization. Please double check. Self generated cert is available for nuxt.options https when enabled

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you explain more? What do you mean?

This was referenced Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants