Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): add scoped helper for clearing error within boundary #20508

Merged
merged 1 commit into from Apr 29, 2023
Merged

feat(nuxt): add scoped helper for clearing error within boundary #20508

merged 1 commit into from Apr 29, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #20453

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a helper to clear error within NuxtErrorBoundary to avoid confusing behaviour with handling error.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu April 25, 2023 21:24
@danielroe danielroe self-assigned this Apr 25, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 25, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 25, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview faa48bb

@danielroe danielroe added this to the v3.5 milestone Apr 26, 2023
@danielroe danielroe changed the title fix(nuxt): add scoped helper for clearing error within boundary feat(nuxt): add scoped helper for clearing error within boundary Apr 26, 2023
@danielroe danielroe merged commit e1e3d2c into main Apr 29, 2023
18 checks passed
@danielroe danielroe deleted the fix/clear-error-boundary branch April 29, 2023 22:32
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@antfu antfu antfu approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug dx 🍰 p2-nice-to-have
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.

Using error = null in template syntax cannot clear errors
3 participants
@danielroe @pi0 @antfu