Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): call app:error in SSR before rendering error page #20511

Merged
merged 3 commits into from Apr 26, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #20183
resolves #20113

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR calls app:error when there's an error rendering to string and we'll directly return an error page. (Previously, it only caught fatal errors in Nuxt plugins.) That allows us to hook into this for setting cookies, for example, as well as to provide some consistency when handling errors with hooks registered in nuxt plugins, and so on.

The one downside is that fatal errors in Nuxt plugins will now result in two calls to app:error.

Alternatively, we could call app:rendered here - or add another hook (app:render:error?).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 25, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 25, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 343ee2a

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@danielroe danielroe changed the title fix(nuxt): call app:error on server before rendering error page fix(nuxt): call app:error in SSR before rendering error page Apr 26, 2023
@danielroe danielroe merged commit 197de3e into main Apr 26, 2023
18 checks passed
@danielroe danielroe deleted the fix/error-cookies branch April 26, 2023 13:37
This was referenced Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cookie value lost if template has error Error hooks don't catch html render error on SSR
2 participants