fix(nuxt): call app:error
in SSR before rendering error page
#20511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #20183
resolves #20113
β Type of change
π Description
This PR calls
app:error
when there's an error rendering to string and we'll directly return an error page. (Previously, it only caught fatal errors in Nuxt plugins.) That allows us to hook into this for setting cookies, for example, as well as to provide some consistency when handling errors with hooks registered in nuxt plugins, and so on.The one downside is that fatal errors in Nuxt plugins will now result in two calls to
app:error
.Alternatively, we could call
app:rendered
here - or add another hook (app:render:error
?).π Checklist