feat(kit): addBuildPlugin for builder-agnostic implementation
#20587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8 tasks
pi0
reviewed
May 14, 2023
| if (pluginFactory.webpack) { | ||
| addWebpackPlugin(pluginFactory.webpack, options) | ||
| } | ||
| } |
There was a problem hiding this comment.
Just an idea: This function would also check if current builder is supported or not and make a warning a build plugin is added without vite/webpack support
There was a problem hiding this comment.
I love the idea. Also maybe provide verbose warning and suggestion in module building mode?
There was a problem hiding this comment.
For module building (i guess testing is only possible) we could do if partial in either case too :)
pi0
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this adds a provider agnostic utility that can pass an object with keys (vite/webpack/rspack), each of which is a factory function for a plugin. This could be used to directly pass an
unplugin, for example, and means that we can also 'upgrade' a module or integration if we + unplugin later support more builders (rspackbeing a case-in-point). All we would do is call the (new) factory function, if it exists.📝 Checklist