Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): always inline styles for server/island components #20599

Merged
merged 15 commits into from May 11, 2023
Merged

fix(nuxt): always inline styles for server/island components #20599

merged 15 commits into from May 11, 2023

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

resolve #20582

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 currently disabling experimental.inlineSSRStyles leads to missing styles for server/islands components.
This PR keep it enabled for server/islands components even if it is disabled (or if there's a function)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 30, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@huang-julien huang-julien marked this pull request as draft April 30, 2023 20:41
@huang-julien huang-julien marked this pull request as ready for review April 30, 2023 21:22
@huang-julien huang-julien marked this pull request as draft April 30, 2023 21:50
@huang-julien huang-julien changed the title fix(nuxt): inline SSR styles for server/islands components fix(nuxt): always inline SSR styles for server/islands components Apr 30, 2023
@huang-julien huang-julien marked this pull request as ready for review May 1, 2023 08:55
@danielroe danielroe mentioned this pull request May 1, 2023
Merged
8 tasks
@huang-julien huang-julien marked this pull request as draft May 1, 2023 12:31
@danielroe danielroe added this to the v3.5 milestone May 2, 2023
@huang-julien huang-julien mentioned this pull request May 2, 2023
Merged
8 tasks
@nuxt-studio
Copy link

nuxt-studio bot commented May 10, 2023 •
edited

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 9a230c1

@huang-julien huang-julien force-pushed the fix/server_component_no_injectStyles branch from 6a033d8 to ac64ad2 Compare May 10, 2023 19:12
@huang-julien huang-julien marked this pull request as ready for review May 11, 2023 20:38
@danielroe danielroe changed the title fix(nuxt): always inline SSR styles for server/islands components fix(nuxt): always inline styles for server/island components May 11, 2023
@danielroe danielroe merged commit 90ab1b5 into nuxt:main May 11, 2023
18 checks passed
This was referenced May 11, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

@huang-julien huang-julien

Labels
3.x bug 🔨 p3-minor-bug
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.

No styles for server component if experimental.inlineSSRStyles is turned off
2 participants
@huang-julien @danielroe