Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix fetch composable examples #20603

Merged
merged 7 commits into from May 1, 2023

Conversation

enkot
Copy link
Contributor

@enkot enkot commented May 1, 2023

πŸ”— Linked issue

#14736

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Comments in the custom fetch composable example is not correct and can be confusing, because onResponse and onResponseError don't allow to return new data/error as shown in the example.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented May 1, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
Copy link
Member

May be worth showing how you can modify the response instead?

@enkot enkot changed the title fix(docs): fixes custom fetch composable example fix(docs): fixes fetch composable examples May 1, 2023
@nuxt-studio
Copy link

nuxt-studio bot commented May 1, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview c332259

@danielroe
Copy link
Member

Nice πŸ‘Œ

@danielroe danielroe changed the title fix(docs): fixes fetch composable examples docs: fix fetch composable examples May 1, 2023
@danielroe danielroe merged commit ecb2fda into nuxt:main May 1, 2023
18 checks passed
@github-actions github-actions bot mentioned this pull request May 1, 2023
@github-actions github-actions bot mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants