Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack): warn when using deprecated build.extend hook #20605

Merged
merged 6 commits into from May 8, 2023
Merged

fix(webpack): warn when using deprecated build.extend hook #20605

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08e3479
fix(webpack): remove support for deprecated `build.extend`
danielroe May 1, 2023
4d8f2e0
feat: warn when `build.extend` is present in user projects
danielroe May 3, 2023
6d3b450
Merge remote-tracking branch 'origin/main' into fix/build-extend
danielroe May 3, 2023
e8ef8c5
Merge remote-tracking branch 'origin/main' into fix/build-extend
danielroe May 4, 2023
4943c09
fix: only deprecate `build.extend` for now
danielroe May 4, 2023
1bd0e6b
Merge branch 'main' into fix/build-extend
danielroe May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 1 addition & 26 deletions packages/webpack/src/utils/config.ts
View file
Open in desktop
Expand Up @@ -57,31 +57,6 @@ export function fileName (ctx: WebpackConfigContext, key: string) {
}

export function getWebpackConfig (ctx: WebpackConfigContext): Configuration {
const { options, config } = ctx

// TODO
const builder = {}
const loaders: any[] = []

// @ts-expect-error TODO: remove support for `build.extend` in v3.5
const { extend } = options.build
danielroe marked this conversation as resolved.
Show resolved Hide resolved
if (typeof extend === 'function') {
const extendedConfig = extend.call(
builder,
config,
{ loaders, ...ctx }
) || config

const pragma = /@|#/
const { devtool } = extendedConfig
if (typeof devtool === 'string' && pragma.test(devtool)) {
extendedConfig.devtool = devtool.replace(pragma, '')
logger.warn(`devtool has been normalized to ${extendedConfig.devtool} as webpack documented value`)
}

return extendedConfig
}

// Clone deep avoid leaking config between Client and Server
return cloneDeep(config)
return cloneDeep(ctx.config)
}